Allow model rendering code to use polymodel_instance. #486
Merged
Conversation
…iance on ship_model_start/stop for rendering models. Also fix a bunch of oversights involving blown off models in the polymodel_instance code.
Member
There was a problem hiding this comment.
Was this line supposed to be removed?
Contributor
Author
|
Yes, that line was intentionally replaced. Blown_off needs to match the bsp_info's damage state. |
Member
|
Yeah, okay, but why set that variable twice, once to what I assume is a correct value and then to false immediately after that? |
Member
|
Point is, either line 4556 or line 4558 should be removed. |
Member
|
I was inquiring whether or not you intended to remove the line, not asking why you did, because... you didn't. |
Contributor
Author
|
The line below is supposed to be removed. I thought I saw |
Contributor
Author
|
It's fixed. |
The-E
added a commit
that referenced
this pull request
Dec 3, 2015
Allow model rendering code to use polymodel_instance.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the reliance on ship_model_start/stop for rendering models. Also fix a bunch of oversights involving blown off models in the polymodel_instance code.